Use the controller for topic metadata requests #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Feb 6, 2020
| @@ -473,7 +473,7 @@ def delete_topics(self, topics, timeout_ms=None): | |||
| return response | |||
|
|
|||
|
|
|||
| def _get_cluster_metadata(self, topics=None, auto_topic_creation=False): | |||
There was a problem hiding this comment.
it'd be cleaner if we could specify the broker ID here, and then the caller can pass in a function that identifies the controller... but looks like that's not how self._send_request_to_controller() is wired up. And it'd be hard to change because of needing to handle retries. So let's just go with this as-is (especially since it's non-public).
|
I'll wait for travis and then will merge. Be nice to have tests for this describe/list topics stuff, but I'm going to merge this one regardless since it's a clear bug. |
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1994
This change is