kafka-python: Fixed crc32c availability on non-intel architectures. #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ossdev <ossdev@puresoftware.com>
|
Nice, thank you! |
tvoinarovskyi
approved these changes
Sep 19, 2019
ossdev07
changed the title
jeffwidman
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requirements-dev.txt: The crc32c version mentioned in this file is 1.5, which fails to compile on non-intel archs. Refer ICRAR/crc32c#6 . It has been fixed since version 1.6.
tox.ini: As mentioned in crc32c github page https://github.com/ICRAR/crc32c , all non-intel architectures have to use the software implementation of it since the hardware its specific to isn't available on non-intel archs. So, to successfully run the test cases, we need to set the environment variable
CRC32C_SW_MODE = auto.This change is