Fix typo in _fetch_all_topic_metadata function #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, thanks for catching that. Hmm, not sure about test coverage... clearly not! If you have time to add one, we'd certainly appreciate it: #1810. Even a basic one would have caught this. |
Baisang
added a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jeffwidman wow, this is really embarrassing. I just noticed there's a typo in #1781, so I corrected it.
It's weird it wasn't caught by any tests -- do we not do any testing for these methods?
This change is