Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL connection testing in Python 3.7 #1669

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Conversation

silentben
Copy link

@silentben silentben commented Dec 6, 2018

This change is Reviewable

@silentben
Copy link
Author

This is based on @seanthegeek's pull request 1661 but cleaned up a bit (just one commit to one specific file)

I'm not sure why it's still showing the integration test as "pending" when it actually completed successfully if you click through at https://travis-ci.org/dpkp/kafka-python/builds/464615729?utm_source=github_status&utm_medium=notification

This closes #1549

@danjo133
Copy link
Contributor

What is stalling this? Support for 3.7 would be super nice!

@silentben
Copy link
Author

@dpkp happy new year! is it possible to merge this so we can run on python 3.7?

@jeffwidman
Copy link
Collaborator

Thanks @silentben / @seanthegeek!

Merging now.

@AlmogCohen
Copy link

Thanks! Was it released to PyPi?

@AlmogCohen
Copy link

I'm asking as I keep getting this error locally :)

@AlmogCohen
Copy link

I'd be happy if you can release that so I take my project back to 3.7 :) Thanks!

@dpkp
Copy link
Owner

dpkp commented Jan 14, 2019 via email

@AlmogCohen
Copy link

I can take a look. I got a bit confused in the repo as I thought it was already merged. Where would I find the latest work that includes the 3.7 fix and failed travis build? some branch?

@dpkp
Copy link
Owner

dpkp commented Jan 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants