Improve connection handling when bootstrap list is invalid #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout in check_version
|
See comments in #1473 (comment) |
This was referenced May 28, 2018
ofek
pushed a commit
to DataDog/integrations-core
that referenced
this pull request
May 29, 2018
This bumps to 1.4.3 which removed the DNS retries when the bootstrap brokers list contained a failing broker: dpkp/kafka-python#1507
|
Hi @dpkp, thanks for this update. I'm working through integrating it now, but I'm finding that when I instantiate a |
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
* only perform single dns lookup for connect_blocking() * fix blocking timeout in check_version()
88manpreet
pushed a commit
to Yelp/kafka-python
that referenced
this pull request
Aug 1, 2018
* only perform single dns lookup for connect_blocking() * fix blocking timeout in check_version()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1473 . This change drops the DNS retries that I had originally included. This should return us to the prior behavior where attempting to start a kafka-python client with invalid bootstrap metadata (or a failing DNS system) will raise an exception.