Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SimpleProducer to use async_send (async is reserved in py37) #1454

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

dpkp
Copy link
Owner

@dpkp dpkp commented Mar 22, 2018

async is a reserved word in python 3.7. I've renamed the SimpleProducer async to async_send and updated the docs. Applications that pass async= will get a deprecation warning in the logs but we'll continue to allow for now by checking **kwargs.

Ref #1451

Copy link
Collaborator

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, can you update the PR description since the kwargs workaround no longer breaks the old async argument usage (IIUC)... I know when I'm trying to come up to speed on something, I often review the PR comment for the high-level overview.

@dpkp dpkp merged commit b62006a into master Mar 23, 2018
@dpkp dpkp deleted the simple_producer_async_send branch March 24, 2018 13:27
@dpkp dpkp mentioned this pull request May 25, 2018
88manpreet pushed a commit to Yelp/kafka-python that referenced this pull request Aug 1, 2018
88manpreet pushed a commit to Yelp/kafka-python that referenced this pull request Aug 1, 2018
@Amr-Abouelleil-bose
Copy link

Amr-Abouelleil-bose commented Mar 11, 2019

Has this fix been integrated into a kafka-python release? The documentation page still indicates python-kafka is only compatible with 3.6 and lower.

https://kafka-python.readthedocs.io/en/master/

@dpkp
Copy link
Owner Author

dpkp commented Mar 11, 2019 via email

charettes pushed a commit to zapier/kafka-python that referenced this pull request Jun 26, 2019
charettes pushed a commit to zapier/kafka-python that referenced this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants