Add Admin CreatePartitions API call #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexef
commented
Feb 18, 2018
| @@ -42,4 +42,6 @@ | |||
| 31: 'DeleteAcls', | |||
| 32: 'DescribeConfigs', | |||
| 33: 'AlterConfigs', | |||
| 36: 'SaslAuthenticate', | |||
There was a problem hiding this comment.
I saw it was missing, but anyway where is API_KEYS used?
kafka/protocol/admin.py
Outdated
| API_KEY = 37 | ||
| API_VERSION = 0 | ||
| SCHEMA = Schema( | ||
| ('topic_error_codes', Array( |
There was a problem hiding this comment.
Seems like you missed throttle_time_ms field. Lets set the name to topic_errors to be exact to docs also. See https://kafka.apache.org/protocol#The_Messages_CreatePartitions.
There was a problem hiding this comment.
Ouch, my bad, pushed a fix.
There was a problem hiding this comment.
Is Line 335 in kafka/admin/client.py a residual mistake from this change?
tvoinarovskyi
requested changes
Feb 19, 2018
|
@tvoinarovskyi thank you for the review! Is there something else I need to do to get this merged, or just wait for more approval? |
|
Looked good to me, so I merged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using it for some time in a personal project.
Protocol should match:https://github.com/apache/kafka/blob/1.0/clients/src/main/java/org/apache/kafka/common/requests/CreatePartitionsRequest.java and https://github.com/apache/kafka/blob/1.0/clients/src/main/java/org/apache/kafka/common/requests/CreatePartitionsResponse.java
This change is