-
Notifications
You must be signed in to change notification settings - Fork 159
Fixed improper JSON response from apis that use quote summary #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JNewman-cell
wants to merge
13
commits into
dpguthrie:master
Choose a base branch
from
JNewman-cell:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@dpguthrie @maread99 I fixed this issue I was running into personally, there is more documentation here if you need to read through it |
JNewman-cell
added a commit
to JNewman-cell/StockInformationWebsiteGithubActions
that referenced
this pull request
Oct 24, 2025
Fixed valuation measures api
Added current valuation measures api to get the most recent stats
Fixed bug where multi ticker calls for current valuation measures was…
Fixed bug when using current valuation with multiple tickers
Updated the news endpoint for the updated yahoo finance api call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling any quoteSummary-based property (such as asset_profile, earnings, financial_data, key_stats, etc.) via the yahooquery package, the returned values exhibit inconsistent response structures depending on the ticker and asset type:
This systematic inconsistency affects 15 out of 17 quoteSummary properties and causes downstream code that expects consistent dict-of-dicts structures to fail or misinterpret responses across different asset classes.
Real-world Impact
This GitHub Actions run is a real-world example of someone expecting a parsable JSON response yet receiving an unexpected response from the API.
https://github.com/JNewman-cell/StockInformationWebsiteGithubActions/actions/runs/18789336097/job/53615494426
Behavior
Old Response: {'EAI': 'No fundamentals data found for symbol: EAI'}
New Response: { "error": { "code": 404, "type": "NotFoundError", "message": "No fundamentals data found for symbol: EAI", "symbol": "EAI" } }