Skip to content

Examples: Python3 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2016
Merged

Examples: Python3 #8

merged 3 commits into from
Apr 14, 2016

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Apr 14, 2016

This pull-request fixes some of the issues reported with Python3 in the examples (see #7).

  • convert scripts to be python 3 compatible (2to3)
  • move .so files as in simpleexample since the library name seems to be different in python 3 compiles
  • backwards compatible with python 2

ax3l added 3 commits April 14, 2016 09:43
Make `FORTHON` a makefile a variable with the default to `Forthon`
so one can externally set it to an alias if necessary.
@dpgrote
Copy link
Owner

dpgrote commented Apr 14, 2016

Thanks for the fixes. BTW, one could also make python a variable, PYTHON, which is what I do in my Makefiles, for example with Warp.

@dpgrote dpgrote merged commit e1b7aff into dpgrote:master Apr 14, 2016
@ax3l ax3l deleted the fix-examplesPy3 branch April 14, 2016 18:49
@ax3l
Copy link
Contributor Author

ax3l commented Apr 14, 2016

valid point, I will send you a follow-up PR!

ax3l added a commit to ax3l/Forthon that referenced this pull request Apr 14, 2016
Follow-up to the annotation in dpgrote#8 to make
`python` itself a variable in the example
Makefiles, too.
ax3l added a commit to ax3l/Forthon that referenced this pull request Apr 14, 2016
Follow-up to the annotation in dpgrote#8 to make
`python` itself a variable in the example
Makefiles, too.
ax3l added a commit to ax3l/Forthon that referenced this pull request Apr 15, 2016
Follow-up to the annotation in dpgrote#8 to make
`python` itself a variable in the example
Makefiles, too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants