Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add_view menu_cond #1922

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add_view menu_cond #1922

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c670013
fix add_view menu_cond
Sep 8, 2022
13a9a5b
remove sys import
Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion flask_appbuilder/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ def get_attr_filter(self, obj, item):

@app_template_filter("is_menu_visible")
def is_menu_visible(self, item):
return self.security_manager.has_access("menu_access", item.name)
if item.cond is None or item.cond():
return self.security_manager.has_access("menu_access", item.name)
return False

@staticmethod
def find_views_by_name(view_name):
Expand Down