Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the security api to request for a JWT token when MongnDB is used #1598

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

yuyou
Copy link

@yuyou yuyou commented Apr 2, 2021

Description

Fixed issue #1405

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@yuyou yuyou changed the title fixed the security api to request for a JWT token when MongnDB is used fix: the security api to request for a JWT token when MongnDB is used Apr 2, 2021
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #1598 (887b4cb) into master (328adb6) will decrease coverage by 6.42%.
The diff coverage is 22.22%.

❗ Current head 887b4cb differs from pull request most recent head c8ea586. Consider uploading reports for the commit c8ea586 to get more accurate results

@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
- Coverage   77.74%   71.32%   -6.43%     
==========================================
  Files          70       56      -14     
  Lines        8560     8236     -324     
==========================================
- Hits         6655     5874     -781     
- Misses       1905     2362     +457     
Flag Coverage Δ
python 71.32% <22.22%> (-6.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/fields.py 70.50% <ø> (ø)
flask_appbuilder/models/mongoengine/filters.py 0.00% <ø> (-68.58%) ⬇️
flask_appbuilder/models/mongoengine/interface.py 0.00% <0.00%> (-77.50%) ⬇️
flask_appbuilder/security/api.py 90.69% <ø> (ø)
flask_appbuilder/forms.py 96.52% <66.66%> (-1.67%) ⬇️
flask_appbuilder/security/mongoengine/models.py 0.00% <0.00%> (-89.34%) ⬇️
flask_appbuilder/security/mongoengine/manager.py 0.00% <0.00%> (-66.16%) ⬇️
flask_appbuilder/models/mongoengine/fields.py 41.66% <0.00%> (-27.78%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added the stale label Sep 6, 2021
@stale stale bot removed the stale label Nov 28, 2021
@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Feel free to reopen it if it's still relevant to you. Thank you

@stale stale bot added the stale label Apr 27, 2022
@stale stale bot removed the stale label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants