Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix, do not panic on unimplemented ordering #1243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix, do not panic on unimplemented ordering #1243

wants to merge 2 commits into from

Conversation

CameronNemo
Copy link
Contributor

Sometimes a column cannot be ordered, and the app panics. This gives a friendly warning and renders the list without the ordering applied.

dpgaspar
dpgaspar requested changes Jan 16, 2020
View reviewed changes
Copy link
Owner

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, can you please add tests for MVC and API

@CameronNemo
Copy link
Contributor Author

Wish I could remember what triggered these panics. IIRC it was the use of formatters_columns or maybe the renders decorator?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api bug mvc MVC pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CameronNemo @dpgaspar