Stoppable process. #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpfaffenbauer
requested changes
Feb 10, 2020
added 2 commits
February 10, 2020 10:50
|
Good, the workflow is that PM only sets the status, the process it self needs to check if the status has been changed right? |
|
Exactly. I have PoC ready for Import Defitnions here: https://github.com/w-vision/DataDefinitions/pull/246nd=1 |
dpfaffenbauer
requested changes
Mar 23, 2020
README.md
Outdated
| Additionally, you need to implement stop logic to your process. Track the process status and stop your process if it's set to `ProcessManagerBundle::STATUS_STOPPING`: | ||
|
|
||
| ```php | ||
| $process = $this->processRepository->findOneBy(['id' => $processId]); |
|
I think other than my comment, it seems fine |
Changed findOneBy() into find() in stoppable process instructions.
|
thanks a lot, again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added status and stoppable columns to processes table, also to all classes connected to Process model.
Status is displayed in the admin panel as an additional column. If the process is running and has stoppable flag set to true, button will show up in admin panel, which would change the status of the process to "stopping".
This way processes can detect if the user wants to stop given process and do so.