feature: artifact support, handle no artifact attached in UI

dpfaffenbauer · Oct 24, 2018 · 9b76e49 · 9b76e49
1 parent 8c07e8e
commit 9b76e49
Showing 1 changed file with 22 additions and 10 deletions.
diff --git a/src/ProcessManagerBundle/Resources/public/pimcore/js/processes.js b/src/ProcessManagerBundle/Resources/public/pimcore/js/processes.js
@@ -211,17 +211,29 @@ pimcore.plugin.processmanager.processes = Class.create({
                 {
                     text : t('processmanager_artifact_download'),
                     xtype:'actioncolumn',
-                    width:50,
-                    items: [
-                        {
-                            iconCls : 'pimcore_icon_download',
-                            tooltip: t('processmanager_artifact_download'),
-                            handler: function(grid, rowIndex) {
-                                var id = grid.getStore().getAt(rowIndex).get('artifact');
-                                pimcore.helpers.download("/admin/asset/download?id=" + id)
-                            }.bind(this)
+                    width: 50,
+                    renderer: function(value, metadata, record) {
+                        var artifact = record.data.artifact;
+                        if (!artifact) {
+                            return;
                         }
-                    ]
+
+                        var id = Ext.id();
+                        Ext.defer(function () {
+                            if (Ext.get(id)) {
+                                new Ext.button.Button({
+                                    renderTo: id,
+                                    iconCls: 'pimcore_icon_download',
+                                    cls: 'processmanager_artifact_download',
+                                    handler: function () {
+                                        pimcore.helpers.download("/admin/asset/download?id=" + artifact)
+                                    }
+                                });
+                            }
+                        }, 50);
+
+                        return Ext.String.format('<span id="{0}"></span>', id);
+                    }
                 },
                 {
                     xtype:'actioncolumn',