Repository navigation
Make :enabled the complement of :disabled, fieldsets included - #190
Merged
Merged
Conversation
jdalton
force-pushed
the
fix/disabled-complement
branch
2 times, most recently
from
September 5, 2026 02:48
a8ec97d to
cfa2a0e
Compare
Collaborator
Author
|
This one sits with #191 and #192 and #193, which touch the conformance fixes found by comparing against Chromium. They do not depend on each other. All seventeen in the series cherry-pick onto master in any order, and I checked that in both directions, so any one of these can land alone. The order below is the one they read best in: |
This was referenced Sep 5, 2026
jdalton
force-pushed
the
fix/disabled-complement
branch
4 times, most recently
from
September 6, 2026 11:40
1910078 to
bd57ded
Compare
jdalton
force-pushed
the
fix/disabled-complement
branch
from
September 6, 2026 14:16
bd57ded to
e0b8663
Compare
jdalton
added a commit
that referenced
this pull request
Sep 17, 2026
jdalton
added a commit
that referenced
this pull request
Sep 17, 2026
Consolidated commits: - d8158d9 Read the last token of a selector that ends in a nested pseudo-class (#182) Original author: John-David Dalton <jdalton@users.noreply.github.com> - e0087aa Keep enabled and disabled states complementary (#190) Original author: John-David Dalton <jdalton@users.noreply.github.com> - 3526e0c Use agent-aware test reporters Original author: jdalton <john.david.dalton@gmail.com> - 0b43903 Share jsdom adapter configuration per document (#213) Original author: John-David Dalton <jdalton@users.noreply.github.com> - 4fe8b2c fix: correct form states, defined elements and relative has anchors Original author: John-David Dalton <jdalton@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Use one disabled-state predicate for :disabled, :enabled, :read-only, and :read-write. A disabled fieldset exempts only descendants of its first legend. Nested fieldsets cannot erase an outer restriction. Options inherit disabled state from their immediate optgroup, not their select or fieldset.
Tests
Focused regressions cover first and later legends, nested fieldsets, own disabled state, non-controls, option groups, and DOM changes. The complete local Docker CI workflow passes, including Node tests, package checks, Chromium, WPT on both builds, and unchanged coverage thresholds.