Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-703] Unit test for reusable paragraph #1444

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-703

What I did

  • Replace jest with vitest in pnpm test:unit
  • Added test for reusable paragraph to demonstrate passthrough to basic_text

How to test

  • pnpm test:unit

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.26.0 milestone Feb 10, 2025
@waitingallday waitingallday self-assigned this Feb 10, 2025
Copy link

cypress bot commented Feb 10, 2025

ripple-framework    Run #2553

Run Properties:  status check passed Passed #2553  •  git commit 689526548e: refactor: :wastebasket: remove jest from root repo
Project ripple-framework
Branch Review feat/vitest
Run status status check passed Passed #2553
Run duration 11m 15s
Commit git commit 689526548e: refactor: :wastebasket: remove jest from root repo
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 235
View all changes introduced in this branch ↗︎

@waitingallday waitingallday requested a review from lambry February 10, 2025 05:05
@waitingallday waitingallday changed the title [SD-703] Unit rest for reusable paragraph [SD-703] Unit test for reusable paragraph Feb 10, 2025
@waitingallday waitingallday merged commit 1df1309 into release/2.26.0 Feb 10, 2025
13 of 14 checks passed
@waitingallday waitingallday deleted the feat/vitest branch February 10, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants