Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding note for analitics logEvent function #619

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

etcho
Copy link

@etcho etcho commented Apr 26, 2021

Informing that the eventName parameter of the logEvent function does not allow dots in the string. Took me some time debugging to find this out.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

Informing that the eventName parameter of the logEvent function does not allow dots in the string. Took me some time debugging to find this out.
@etcho etcho changed the title Adding not for analitics logEvent function Adding note for analitics logEvent function Apr 26, 2021
@dpa99c dpa99c changed the base branch from master to dev June 16, 2021 08:18
@dpa99c dpa99c merged commit aa93dcc into dpa99c:dev Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants