Skip to content

Hoist non react statics #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Hoist non react statics #35

merged 3 commits into from
Aug 9, 2018

Conversation

hartzis
Copy link
Collaborator

@hartzis hartzis commented Aug 8, 2018

dev:

  • updated phantomJS
  • added es6-shim for tests

@hartzis hartzis mentioned this pull request Aug 8, 2018
7 tasks
@hartzis hartzis force-pushed the hoist-non-react-statics branch from 9f59eab to 1f4d15f Compare August 8, 2018 04:06
@hartzis
Copy link
Collaborator Author

hartzis commented Aug 8, 2018

Looks like upgrading react is failing the tests with:

PhantomJS 1.9.8 (Linux 0.0.0) ERROR
  ReferenceError: Can't find variable: Set
  at /home/travis/build/dozoisch/react-async-script/test/index.js:2376 <- webpack:///~/react-dom/cjs/react-dom.production.min.js:126:0

🤔 ....

@hartzis hartzis added this to the v1.0.0 milestone Aug 8, 2018
@dozoisch
Copy link
Owner

dozoisch commented Aug 8, 2018

(I just merged your other branch if you want to rebase!)

Hmm, I'm suspecting that the new react version requires a Set polyfill when using it.

@dozoisch dozoisch merged commit da7120d into master Aug 9, 2018
@dozoisch dozoisch deleted the hoist-non-react-statics branch August 9, 2018 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants