Skip to content

Conversation

@mrchief
Copy link
Collaborator

@mrchief mrchief commented Feb 23, 2020

What does it do?

Guards against accessing null ref with inline search input.

Fixes # (issue)

Fixes #335

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c796ab2 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1336

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 95.156%

Totals Coverage Status
Change from base Build 1328: -0.07%
Covered Lines: 586
Relevant Lines: 599

💛 - Coveralls

@mrchief mrchief merged commit 04309d7 into develop Feb 23, 2020
@mrchief mrchief deleted the fix/search_input_null branch February 23, 2020 01:16
@mrchief
Copy link
Collaborator Author

mrchief commented Feb 23, 2020

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError when combining clearSearchOnChange and inlineSearchInput

3 participants