Skip to content

Conversation

@mrchief
Copy link
Collaborator

@mrchief mrchief commented Sep 29, 2019

What does it do?

Ancestor nodes, that contained match term, were always marked hidden or translucent if a child node contained the match term. This PR fixes that issue.

Fixes # (issue)

Fixes #291

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 14d8c64 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1293

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 95.294%

Totals Coverage Status
Change from base Build 1281: 0.01%
Covered Lines: 587
Relevant Lines: 600

💛 - Coveralls

@mrchief mrchief merged commit 423a5e4 into develop Sep 29, 2019
@mrchief mrchief deleted the fix/ancestor-match branch September 29, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't hide tree items if they contain the search term

3 participants