disable dropdown onClick search box

[moonjy1993]

Hello,

Is there way to force dropdown content open? or like any disable when onClick of search box so that I can force the dropdown always expanded? if not, do you have any plan to implement such props?

Thank you very much for reading this.

[mrchief]

You can probably use showDropdown to accomplish this.

[moonjy1993]

@mrchief thanks for the reply.
unfortunately, showDropdown is only to intialiaze the state of dropdown.
I am looking for a props that always keeps dropdown expanded.

[mrchief]

@moonjy1993 I was thinking more like using showDropdown and hiding the dropdown toggle with CSS. But even with that, any outside click will close it.

So, unfortunately, the answer to your question is no.

Implementing this change seems simple though. Something like this should do the trick, I think:

const showDropdown = this.props.showDropdownAlways || this.keepDropdownActive || !prevState.showDropdown

I can get to it sometime but if you want this soon, feel free to send me a PR.

[moonjy1993]

@mrchief Hi, thank you for your response!
I will create a PR soon.

[mrchief]

@moonjy1993 Great! Will look forward to it.

Got few things in my mind as I think about this:

• would it be better to disable register the outsideClick handler for showDropdownAlways?
• Maybe we can bundle this new prop and showDropdown into a single one (not in this PR but the bundle props one - showDropdown: initial|always)
• Or we can accept mixed values - true/false for current behavior and "always" for new behavior. This feels like a hack though and I'm not convinced if this is a good pattern (even though JavaScript will let us get away with it).

Thoughts?

/cc @ellinge @Gregcop1

[moonjy1993]

@mrchief

• would it be better to disable register the outsideClick handler for showDropdownAlways?
  Yes. I guess that makes. I will also include that logic in PR.

• Maybe we can bundle this new prop and showDropdown into a single one (not in this PR but the bundle props one - showDropdown: initial|always)

• Or we can accept mixed values - true/false for current behavior and "always" for new behavior. This feels like a hack though and I'm not convinced if this is a good pattern (even though JavaScript will let us get away with it).

This is something you guys(author) can decide, but I will be fine with either way.
But this might confuse the current/future users, I think. showDropdown is for setting initialState, and showDropdownAlways is forcing the state..?
I dunno...

But, thanks for the review!

[moonjy1993]

@mrchief hi!
I have created PR according to what we've discussed..not sure if you'll be able to review it and merge it soon?

Thank you vm!

[mrchief]

🎉 This issue has been resolved in version 1.19.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀