Conversation
- Remove unused Think action variant from Action enum - Replace silent Think fallback with explicit error messages - Add error feedback when action format is invalid - Store errors in agent memory for self-correction - Add comprehensive tests for invalid action handling This change improves agent robustness by providing clear error feedback when actions are malformed, allowing the agent to observe errors and self-correct rather than silently failing with the Think action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves agent robustness by removing the unused Think action and providing explicit error feedback when actions are malformed.
Changes
use_tool:prefix)Problem Solved
Previously, when the LLM generated malformed actions (like
shell:run_commandwithout theuse_tool:prefix), the agent would silently fall back to the Think action which did nothing. This caused the agent to get stuck in confusion loops without understanding what went wrong.Solution
Now the agent receives clear error messages like:
These errors are stored in memory as
error_<timestamp>entries, allowing the agent to:Test Plan