Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7.2.0 rc #96

Merged
merged 4 commits into from
Jul 12, 2019
Merged

V7.2.0 rc #96

merged 4 commits into from
Jul 12, 2019

Conversation

doug-martin
Copy link
Owner

* Added new dialect option to allow specifying whether or not a compound expression requires parens
* Added check to make sure exp.ExpressionList is not empty to sql_dialect
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #96 into master will decrease coverage by 0.04%.
The diff coverage is 88.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage    86.5%   86.45%   -0.05%     
==========================================
  Files          38       38              
  Lines        2756     2791      +35     
==========================================
+ Hits         2384     2413      +29     
- Misses        323      328       +5     
- Partials       49       50       +1
Impacted Files Coverage Δ
exp/exp.go 22.22% <ø> (ø) ⬆️
sql_dialect_options.go 79.5% <100%> (+0.1%) ⬆️
dataset.go 96.7% <100%> (+0.02%) ⬆️
sql_dialect.go 86.49% <100%> (+0.12%) ⬆️
dialect/sqlite3/sqlite3.go 100% <100%> (ø) ⬆️
exp/exp_list.go 80% <100%> (-5.27%) ⬇️
exp/clauses.go 96.72% <66.66%> (-1.02%) ⬇️
exp/compound.go 57.14% <75%> (ø) ⬆️
exp/exp_map.go 73.95% <85.89%> (+51.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ee44f...e75577a. Read the comment docs.

@doug-martin doug-martin merged commit 3d12ff0 into master Jul 12, 2019
@doug-martin doug-martin deleted the v7.2.0-rc branch October 16, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant