Generic ORDER BY?

[mjs]

Is your feature request related to a problem? Please describe.

I am using goqu to build up queries where specific parts of the query come from another process. This has been working wonderfully (goqu is fantastic!) but I've run into a problem with ORDER BY. Unless I'm missing something, there isn't a way to insert a literal ORDER BY section which means I'll probably have to parse the incoming order by string myself so I can generate the required OrderedExpressions. This is doable but ideally I'd prefer not to.

Describe the solution you'd like

Allow for ORDER BY literals, in a similar way that literals are supported elsewhere.

Describe alternatives you've considered

I guess I might be able to modify the SQL after goqu has generated it but that's just gross.

Dialect

• postgres
• mysql
• sqlite3

Additional context

None.

[mjs]

If you give me some guidance on how you'd like the API for this to work, I might be able to provide a PR.

[doug-martin]

@mjs that would be great!

I want to note I would not recommend taking in input and putting it straight into a Literal as it will not try to escape it. I dont know your use case exactly, but just a word of caution.

I would start in the following Order implementations to accept ex.Expression (You will also need to update the OrderAppend and OrderPrepend sections).

• https://github.com/doug-martin/goqu/blob/master/select_dataset.go#L398
• https://github.com/doug-martin/goqu/blob/master/update_dataset.go#L145
• https://github.com/doug-martin/goqu/blob/master/delete_dataset.go#L140

You'll then need to update the order clauses to accept exp.Expression

• https://github.com/doug-martin/goqu/blob/master/exp/select_clauses.go
• https://github.com/doug-martin/goqu/blob/master/exp/update_clauses.go
• https://github.com/doug-martin/goqu/blob/master/exp/delete_clauses.go

Then you should update https://github.com/doug-martin/goqu/blob/master/exp/col.go#L50 to check that the expressions are either an OrderedExpression or LiteralExpression

I think that should be enough to get you started!

Let me know if you run into any issues.