with table as (insert ... returning ...)

[cmoad]

Is your feature request related to a problem? Please describe.
We are trying to convert a query that has a common table expression that is a result of insert...returning. We are getting the error goqu: unsupported expression type *goqu.InsertDataset from the sql generator.

Describe the solution you'd like
Adding a case for InsertExpression to

goqu/sqlgen/expression_sql_generator.go

Line 140 in 25020dc

func (esg *expressionSQLGenerator) expressionSQL(b sb.SQLBuilder, expression exp.Expression) {

Describe alternatives you've considered
N/A

Dialect

• postgres
• mysql
• sqlite3

Additional context
Opening this issue. We think we know the fix, but need to fork and setup our dev environments to get you a PR. Thanks for all the awesome work lately! We would like to contribute where possible.

[cmoad]

I may have spoken too soon. I attempted to add support for InsertExpression in expression_sql_generator.go, but it's causing an infinite loop in the test case.

Here was the naive attempt:

// Generates SQL for an InsertExpression
func (esg *expressionSQLGenerator) insertExpressionSQL(b sb.SQLBuilder, ie exp.InsertExpression) {
	esg.Generate(b, ie)
}

[doug-martin]

I think I know the fix for this. Ill start diving in today

[doug-martin]

I just issued a PR that addresses this issue. In v9.3.0 you will be able to use Insert, Update or Delete datasets in CTEs and sub queries as long as they have a RETURNING clause.

[cmoad]

Awesome. Thanks for tackling that. Looks like it was more involved than we were expecting.

[doug-martin]

Yeah it could have been less invasive but I decided to go ahead and support all the datasets instead of just insert. I’m going to get the coverage passing and then publish.

Thanks for submitting the feature request!

[doug-martin]

published!