Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyternotebook feature and testing #405

Closed
wants to merge 7 commits into from
Closed

Jupyternotebook feature and testing #405

wants to merge 7 commits into from

Conversation

nan3037
Copy link

@nan3037 nan3037 commented Sep 6, 2022

Description

The backend can accept .ipynb files now. Adding a latex module jupynotex in app\views\layouts\application.pdf.erbtex and new MIME type for ipynb in app\helpers\file_helper.rb.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test was conducted by trying to upload and `.ipynb' file and was run successfully as the file was accepted. Run unit test for the same that passed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nan3037 nan3037 marked this pull request as ready for review September 6, 2022 09:15
@macite macite closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants