Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codes for better user authentication #375

Closed

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Ive added a few layer of codes which allows users to change their user password and allow admins to change user passwords.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

If you have any questions, please contact @macite or @jakerenzella.

@jakerenzella
Copy link
Member

Hi @Krulcii, before reviewing I've noticed the PR template is not completed correctly and the commit message does not adhere to the format found in the contributing document. Can you fix those up? Thanks.

@ghost ghost closed this May 17, 2022
@ghost ghost reopened this May 17, 2022
@macite
Copy link
Member

macite commented May 24, 2022

Hi @Krulcii - please see Jake's earlier comment. Please adjust your commit message format.

Looking at the code I think you can also enhance the structure of the code - I'm not sure that different user roles need different password changing processes.

@macite macite closed this May 24, 2022
@ghost
Copy link
Author

ghost commented May 24, 2022

Hi, sorry where can i find the commit message format?

@ghost ghost deleted the change_user_password branch May 24, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants