Perf/fix project and unit load times #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinstate use of the task_stats field to cache task status counts on update of target grade and tasks status. This improves performance of student query when loading a unit for staff. Co-authored-by: Tan Le <tan.le@hey.com> Co-authored-by: Ray Guo <RayGuo-ergou@users.noreply.github.com> Co-authored-by: talzid <talzid@users.noreply.github.com>
tancnle
reviewed
Mar 10, 2022
|
Thank you for your hard work on this fix @macite ❤️ I have left some suggestions/questions. Please let me know what you think 🙏🏼 |
|
Thanks for the great review @tancnle 👍 - I will address the issues raised and update ASAP. |
|
I agree, this is a great review @tancnle thank you! |
|
Thank you @macite 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reinstates the task_stats data for the front end and improves the load time performance of units. This is done by caching the task_stats in the project and updating this on task status change and change of target grade. As a result, this can be loaded from the database on the students query.