config: update of gem, docker files and ruby and rails version #324
Conversation
| @@ -2,12 +2,12 @@ FROM ubuntu:18.04 | |||
|
|
|||
| RUN apt-get update && apt-get install -y curl git | |||
| ENV PATH /root/.rbenv/bin:/root/.rbenv/shims:$PATH | |||
| RUN curl -fsSL https://github.com/rbenv/rbenv-installer/raw/master/bin/rbenv-installer | bash | |||
| RUN curl -fsSL https://github.com/rbenv/rbenv-installer/raw/HEAD/bin/rbenv-installer | bash | |||
There was a problem hiding this comment.
This seems like an odd place to get the data from. You might want to change this to main instead of HEAD, as that will be more reliable in terms of knowing which branch you're working with.
There was a problem hiding this comment.
@kugamigh this is the updated url in their git repo the previous url had been removed from their repo. when i did docker build it was givine 404 error then i checked the repo url was changed
There was a problem hiding this comment.
Their URL will have changed from:
https://github.com/rbenv/rbenv-installer/raw/master/bin/rbenv-installer
to:
https://github.com/rbenv/rbenv-installer/raw/main/bin/rbenv-installer
|
There is a separate branch to update to rails 6 as this breaks much of the system functionality. We need to update the existing branch to incorporate the overseer updates, rather than recreating this here. |
|
See config/new-rails branch - you will notice it has additional changes that are needed for this update. |
There was a problem hiding this comment.
See config/new-rails branch - you will notice it has additional changes that are needed for this update.
Thank you Prof @macite i'll check it and work on that
| @@ -2,12 +2,12 @@ FROM ubuntu:18.04 | |||
|
|
|||
| RUN apt-get update && apt-get install -y curl git | |||
| ENV PATH /root/.rbenv/bin:/root/.rbenv/shims:$PATH | |||
| RUN curl -fsSL https://github.com/rbenv/rbenv-installer/raw/master/bin/rbenv-installer | bash | |||
| RUN curl -fsSL https://github.com/rbenv/rbenv-installer/raw/HEAD/bin/rbenv-installer | bash | |||
There was a problem hiding this comment.
@kugamigh this is the updated url in their git repo the previous url had been removed from their repo. when i did docker build it was givine 404 error then i checked the repo url was changed
|
I've created a new PR - looks like not much change is needed. Though we will need to update the Overseer code. See #325 |
No description provided.