Add docker as a platform option #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expects that doubtfire-web is cloned to the directory above doubtfire-api
Not everyone will be generating PDFs on the API. If you do you will need LaTeX. A note for this was added to the README and the Dockerfile was updated to remove this.
CI reporter isn't being used and the docker container was failing at this step when trying to run rake tasks
During build there is no access to the doubtfire-db. We will need to execute this once the image is built. See http://stackoverflow.com/a/31542717/519967
This commit allows Doubtfire API to be run under ruby 2.1.2 for development
The start script will try to restore first, then create if the docker-compose service does not exist
The new docker.sh script is essentially the gateway to use Doubtfire and execute commands. Improved error handling and usability of the command means that people without Docker experience can still use Doubtfire via Docker
alexcu
added a commit
that referenced
this pull request
Mar 12, 2016
Add docker as a platform option
|
As docker is now used, the |
macite
referenced
this pull request
in macite/doubtfire-api
Jan 4, 2019
…ng-period CONFIG: Move tasks test file to correct case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Up until now, Doubtfire has been hard to set up especially for novice users. There should be an easy way to get Doubtfire up and running without too much hassle, even for demonstration purposes.
What's Changed?
This pull request adds Docker config to the api so that it is possible to run it via Docker.
To do so, use the extensive
./docker.shscript.