Refactor Gemfile dependencies #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To install gems, we should now use: bundle install --without production replica That is, include the `test` group. Since bundler retains what to not install, previous bundle installations should edit the .bundle/config file and remove "test" from the BUNDLE_WITHOUT config.
|
Is this needed any more? |
|
@macite Yes, this PR makes some changes to the Gemfile grouping so that we don't need mysql2 on the test environment (amongst others). When installing we should now use: as we want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Gemfile to reduce unnessasary installations of gems where possible. It also updates the
:testgroup now that the framework is ready to go (see #25). When #25 is merged, there will be some conflicts since this PR does some minor refactoring on the Gemfile also. I will fix these conflicts, but proposing these changes so that @macite can review what has been modified.In addition, the documentation now removes the
testgroup from the--withoutbundle switch, since testing is to be encouraged. Hence, we want bundler to install thetestgroup.I'm working on a
demobranch Docker image (as discussed with you @macite) here which obviously won't need thetestgroup—this will speedup the time for the Docker image to build and will be helpful in situations where we don't need tests to be installed.