Add minitest framework to begin supporting TDD approach for API changes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for units and change Assert to be Assert_equal where necessary.
PUT Test will POST a unit, test it, PUT an update and test the updated values.
auth_helper manages authentication for all tests that require authentication
Prevent stale branch from occuring
alexcu
changed the title
|
Agreed. Now that the issues are sorted with this I am very keen to move to TDD... including using this when fixing other issues as well etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakerenzella and I discussed switching to a TDD approach to unit testing for API changes. We suggested to merge this branch into
develop; therefore new features (such as the ticketing system) can be branched offdevelopand a TDD approach can be adopted using these additions as a template/guide.Additional tests that are yet to be written for existing APIs can then be branched off developed accordingly, e.g.,
test/api-submission,test/api-group-setsetc.What do you think @macite?