-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feat/media3 newarch #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/media3 newarch #2478
Conversation
Node 22 has entered LTS as of October 2024
example: fix
Brings in media3 & android-auto functionalities from https://github.com/lovegaoshi/react-native-track-player, leaving out widget & audio fading functionalities
- show jump backward & forward buttons in notification - remove compactCapabilities - rename BaseAudioPlayer#player to BaseAudioPlayer#forwardingPlayer
|
Alright, I've fixed the issue where the remote events weren't firing. While I was looking around I found a lot of Android Auto related code that I'm going to strip back out of this PR for the next release. To reiterate, this release is going to focus specifically on media3 and turbomodules. EDIT: I'm going to wait a few days for some community feedback on the remote events. If everything checks out, I plan on releasing a |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hey @jspizziri cool that you fixed the events! :) Could you consinder #2478 (comment) to fix Thanks in advance! ❤️ |
|
Retested the branch and confirm media buttons work on Android in my app. Same on iOS. Tip: when testing this make sure to force close the app completely when changing any options in player. Changing and reloading might break it. |
|
I can confirm the remote events are now fixed for me! Thanks! ❤️ |
This comment has been minimized.
This comment has been minimized.
…-agent for Media3 requests (#2496) Added a custom user-agent string to prevent 403 errors when playing Live365 streams using Media3.
|
@jspizziri @lovegaoshi @puckey Could someone explain where we at with CarPlay & Android Auto? I've used something like @lovegaoshi's approach to carplay & android auto, on stable version of rntp, so far and I'd like to offer my help if there's anything else to be done about carplay, so that we can have proper feature integrated with new rntp version asap. I can tell you that the current issue is with Google, they're rejecting builds that have both Any way, let me know if I can assist in any way. |
|
I’m testing the library on the latest commit (492d349) and here are some considerations that might help... My setup: Android 16 and 15: Everything seems to work fine in the emulator, but on some real devices it doesn’t behave as expected, for example, when trying to use the remote controllers with the expanded notification (OnePlus 11 device). In other cases, the controller only closes if the app itself is closed. Android 12 and 9: NOTHING works, none of the remote events. iOS 18.5: Everything seems to be working very well. EDIT: Using this commit: 0001895 const capabilities = [ const notificationCapabilities = [Capability.Play, Capability.Pause]; if (Platform.OS === "android" && Platform.Version > 31) { With this approach, on Android <= 12, Play, Pause, Skip to Next, and Skip to Previous are enabled and working (even if Skip to Next and Previous are not explicitly enabled). For Android versions above 12, all events work, including the jumps. It’s also worth noting that the issues with the expanded card are still happening on some devices. |
While those issues are very important and a priority for many (including me), this PR specifically is leaving carplay and android auto alone. Right now we're making some needed upgrades to the library that will, ideally pave the way for those things. We can talk about the future of android auto and carplay elsewhere once this has been released and is stable. |
Understandable. Appreciate the answer. |
I can't test what I can't see and reproduce. I'm not sure if this is an actionable statement for me at this point.
Android API Level 35 (Android 15) is now required for all Google Play apps. We will not be supporting those operating systems moving forward. If you need to support them then you'll either need to use an older version of the library or fork. |
|
v5.0.0-alpha0 has been published to npm. |
|
Hi @jspizziri, We’re still encountering a critical issue on Android with react-native-track-player. Error: Environment: Is this a known issue, or are there any recommended workarounds or fixes? This is currently our highest crash source on Android. Thanks for your help 🙏 |
@jspizziri Any idea when this will be stable? It still has bugs on Android like @mcalc001 pointed out. |
|
Should this be updated? It still says that it does not support the newArch. https://reactnative.directory/package/react-native-track-player |
It doesn't. The last official release is still 4.1.2 which doesn't support the New Architecture. The only version of this library that does (although there are known unaddressed bugs) is an alpha version. Alpha versions are generally reserved for internal testing. |
|
Is there a timeline for more updates to this and getting v5 stable and launched? We'd be happy to discuss funding some of this work if it helps. |
TODO:
react-native@0.80.0