feat: support ramping-in of volume #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an RFC for supporting the idea of fading audio in when you play. The idea would be to support AVPlayerWrapper.rampSecs, which, if set to non-zero, fades audio in every time you play. The broader proposal would be to expose this through RNTP at some point so that people can implement players where audio ramps in whenever Play is hit. Eager to hear feedback on this. Alternatives to this include having clients just `setTimeout` themselves, manually calling `setVolume` a bunch of times with incrementally-increasing values, but: a) a native implementation ramps volume much more smoothly, and b) this makes it effortless to create players that always ramp sound in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an RFC for supporting the fading in of audio when you play(). The idea would be to support AVPlayerWrapper.rampSecs, which, if set to non-zero, fades audio in every time you play. The broader proposal would be to expose this through RNTP at some point so that people can implement players where audio ramps in whenever Play is hit.
Eager to hear feedback on this. Alternatives to this include having clients just
setTimeoutthemselves, manually callingsetVolumea bunch of times with incrementally-increasing values, but: a) a native implementation ramps volume much more smoothly, and b) this makes it effortless to create players that always ramp sound in.