Skip to content

Feature/#178 heimat integration #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 75 commits into from
Mar 30, 2025
Merged

Feature/#178 heimat integration #179

merged 75 commits into from
Mar 30, 2025

Conversation

Death111
Copy link
Collaborator

No description provided.

@Death111 Death111 self-assigned this Jan 25, 2025
@Death111 Death111 linked an issue Jan 25, 2025 that may be closed by this pull request
Add integration with "Heimat" #178
Open
Death111 added 17 commits January 25, 2025 22:16
@Death111
#178: transform settings table to key-value table for easier extesion…
0abf2de 
… (not all done yet)
@Death111
#178: add heimat settings in settings layout. add heimat settings to …
c8ec6ff 
…database. started external mapping db-table (wip)
@Death111
#178: fix/restore settings handling
71cf0ea
@Death111
#178: remove VARCHAR limit - check how it looks in db
ce597b4
@Death111
#178: allow to map projects in settings view
03610d9
@Death111
#178: start sync to heimat dialog
f8bef51
@Death111
#178: show times from heimat in sync view for conflict resolution. ad…
71e5ffb 
…d round up/down functionality.
@Death111
#178: show color of project
9152072
@Death111
#178: add initial sync functionality
e73b6dc
@Death111
#178: add red border if not a valid time or note
9185624
@Death111
Merge branch 'feature/#165_Rest-API-New' into feature/#178_heimatInte…
f0bd7af 
…gration
@Death111
#178: refactor logic and add tests for conversion for UI. improve ui.
9283c66
@Death111
#178: close map projects dialog on button. allow project creation in …
84fb254 
…mapping. remove removed mappings.
@Death111
#178: show sync loading screen success/failure message
276632d
@Death111
#178: show error dialog if something goes wrong when opening stages
336a2f8
@Death111
#178: implement shouldShowHeimatTimeWhenProjectIsNotMappedInKeeptime
bf62fa9
@Death111
#178: show current heimat + keeptime times. add copy button. add hype…
3461ce2 
…rlink. make rows non interactable if cannot be synced
@Death111 Death111 force-pushed the feature/#178_heimatIntegration branch from f88b784 to 3461ce2 Compare March 7, 2025 23:19
Base automatically changed from feature/#165_Rest-API-New to develop March 22, 2025 14:29
@Death111 Death111 marked this pull request as ready for review March 22, 2025 14:30
Death111
Death111 commented Mar 22, 2025
View reviewed changes
Death111 added 13 commits March 22, 2025 15:52
@Death111
#178: add license header to new files
a0b1c79
@Death111
#178: rename controller to be consistent
772e63f
@Death111
#178: update spring patch version
7c5cb40
@Death111
#178: report fix selected arrow disappear
8def475
@Death111
#178: fix spelling
d986d51
@Death111
#178: add quick fix for #170
1b6761c
@Death111
#178: fix issue where stoping loading spinner rotation did not reset …
04b6fed 
…rotation
@Death111
#178: check for time diff >= 15minutes instead of > to also sync when…
849fbbf 
… diff is exactly 15min
@Death111
#178: rename variables
58aefe3
@Death111
#178: fix bug where manually added row was creating inconsistent vali…
f675c1a 
…dation (e.g. save button disabled besides everything valid)
@Death111
#178: center sync checkbox horiztonal
3c9ff46
@Death111
#178: add hint for unexpected exception to be reported to a developer
2a07293
@Death111
#178: adding "Sync to" prefix now consistently. scrolling to newly ad…
e755888 
…ded row in sync view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Death111
Copy link
Collaborator Author

Merging besides having a failing Sonar. Sonar complains about test-coverage which is fair. But for the UI-Controllers we do have a test gap for every controller. For non-ui logic we do have tests in place.

@Death111 Death111 merged commit 8d0cd21 into develop Mar 30, 2025
4 of 5 checks passed
@Death111 Death111 deleted the feature/#178_heimatIntegration branch March 30, 2025 16:51
@Death111 Death111 mentioned this pull request Mar 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Death111 Death111

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add integration with "Heimat"
1 participant
@Death111