Add README, list aggregation, explicit reject (Juniper)#3
Open
jthurman42 wants to merge 6 commits intodotwaffle:masterfrom
Open
Add README, list aggregation, explicit reject (Juniper)#3jthurman42 wants to merge 6 commits intodotwaffle:masterfrom
jthurman42 wants to merge 6 commits intodotwaffle:masterfrom
Conversation
…d the specified filter name
Owner
|
Excellent work, thank you! Two quick suggestions before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this script to be extremely useful, thanks a lot for opening it up! I've added a brief README with examples, and a few functional changes.
All of these changes have been tested, and used to generate filters that have been put into production.