Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #1120

Merged
merged 3 commits into from
Aug 29, 2024
Merged

docs: fix typo #1120

merged 3 commits into from
Aug 29, 2024

Conversation

billmetangmo
Copy link
Contributor

🚧 Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • If I add a new feature, there is an issue discussing it already;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • One commit per logical change;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide;
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The documentation is up-to-date;

Consider opening a Draft PR if your work is still in progress but you would
like some feedback from other contributors.

docs/reference/serve/vllm.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@billmetangmo billmetangmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

billmetangmo and others added 2 commits August 29, 2024 09:40
Co-authored-by: Rémi Louf <remilouf@protonmail.com>
@rlouf rlouf merged commit 7cf63d6 into dottxt-ai:main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants