Repository navigation
fix(json_schema): accept numeric time offsets in date-time format - #257
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for opening a PR. I merged your other PR touching at the same part of the code, so there's a conflict now. Could you resolve it please? |
The `date-time` format regex only accepted a `Z` (UTC) suffix, so valid RFC3339 timestamps with a numeric offset such as `2018-11-13T20:20:39+01:00` were rejected. Extend the offset to also match `(+|-)HH:MM` per RFC3339 section 5.6. The offset remains optional, so previously-accepted offset-less strings like `2021-01-01T00:00:00` still match; this is documented in a comment. Closes dottxt-ai#155
pjdurden
force-pushed
the
fix/date-time-numeric-offset
branch
from
August 4, 2026 18:16
b245e59 to
51a010e
Compare
Contributor
Author
|
Rebased onto main. Kept your merged per-month |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
date-timeformat regex only accepted aZ(UTC) suffix, so validRFC3339 timestamps with a numeric offset such as
2018-11-13T20:20:39+01:00were rejected. Extend the offset to also match
(+|-)HH:MMper RFC3339section 5.6.
The offset remains optional, so previously-accepted offset-less strings
like
2021-01-01T00:00:00still match; this is documented in a comment.Closes #155