-
-
Notifications
You must be signed in to change notification settings - Fork 353
feat(ExpandableNodeCache): use RemoveWhere instead of Remove method #5906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Reviewer's Guide by SourceryModify node cache operations in ExpandableNodeCache to explicitly use an EqualityComparer for comparisons. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AiYuZhen - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider initializing the
ExpandedNodeCache
andCollapsedNodeCache
HashSets with theEqualityComparer
directly, which might allow using the more directRemove
method instead ofRemoveWhere
.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@AiYuZhen 为什么要这样更改? |
我在使用 Tabe 组件的 IsTree = true 模式处理菜单记录时,当表格刷新后无法保持各项的折叠状态。 |
Co-Authored-By: wzhq1997 <40653349+wzhq1997@users.noreply.github.com>
69f5952
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5906 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 665 665
Lines 30485 30485
Branches 4345 4345
=========================================
Hits 30485 30485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5913
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements:
IEqualityComparer
forContains
andRemove
/RemoveWhere
operations on the expanded and collapsed node caches.