Skip to content

feat(ExpandableNodeCache): use RemoveWhere instead of Remove method #5906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

AiYuZhen
Copy link
Contributor

@AiYuZhen AiYuZhen commented Apr 27, 2025

Link issues

fixes #5913

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Use an explicit IEqualityComparer for Contains and Remove/RemoveWhere operations on the expanded and collapsed node caches.

Copy link

bb-auto bot commented Apr 27, 2025

Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

sourcery-ai bot commented Apr 27, 2025

Reviewer's Guide by Sourcery

Modify node cache operations in ExpandableNodeCache to explicitly use an EqualityComparer for comparisons.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Use explicit EqualityComparer for cache operations
  • Replace calls to HashSet.Remove with HashSet.RemoveWhere using EqualityComparer.Equals.
  • Replace calls to HashSet.Contains with HashSet.Contains using an explicit EqualityComparer.
src/BootstrapBlazor/Misc/ExpandableNodeCache.cs

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot requested a review from ArgoZhang April 27, 2025 03:50
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Apr 27, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AiYuZhen - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider initializing the ExpandedNodeCache and CollapsedNodeCache HashSets with the EqualityComparer directly, which might allow using the more direct Remove method instead of RemoveWhere.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang
Copy link
Member

@AiYuZhen 为什么要这样更改?
是不是遇到什么问题了?先创建 Issue 然后再来 PR。PR 是为了解决 Issue。Issue 里讲清楚遇到了什么问题,或者解决了什么问题

@AiYuZhen
Copy link
Contributor Author

@AiYuZhen 为什么要这样更改? 是不是遇到什么问题了?先创建 Issue 然后再来 PR。PR 是为了解决 Issue。Issue 里讲清楚遇到了什么问题,或者解决了什么问题

我在使用 Tabe 组件的 IsTree = true 模式处理菜单记录时,当表格刷新后无法保持各项的折叠状态。
我明天弄一个工程。

@bb-auto bb-auto bot requested a review from ArgoZhang April 27, 2025 11:14
@bb-auto bb-auto bot added the bug Something isn't working label Apr 27, 2025
@bb-auto bb-auto bot added this to the v9.5.0 milestone Apr 27, 2025
ArgoZhang
ArgoZhang previously approved these changes Apr 28, 2025
ArgoZhang and others added 2 commits April 28, 2025 18:52
Co-Authored-By: wzhq1997 <40653349+wzhq1997@users.noreply.github.com>
@ArgoZhang ArgoZhang dismissed stale reviews from sourcery-ai[bot] and themself via 69f5952 April 28, 2025 10:53
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (20da007) to head (69f5952).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5906   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          665       665           
  Lines        30485     30485           
  Branches      4345      4345           
=========================================
  Hits         30485     30485           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title feat(ExpandableNodeCache)优化节点缓存操作的比较逻辑 feat(ExpandableNodeCache): use RemoveWhere instead of Remove method Apr 28, 2025
@ArgoZhang ArgoZhang merged commit b7759e7 into dotnetcore:main Apr 28, 2025
6 checks passed
@AiYuZhen AiYuZhen deleted the Feat_ExpandableNodeCache branch April 29, 2025 00:10
@AiYuZhen AiYuZhen restored the Feat_ExpandableNodeCache branch April 29, 2025 00:10
@AiYuZhen AiYuZhen deleted the Feat_ExpandableNodeCache branch April 29, 2025 00:10
@AiYuZhen AiYuZhen restored the Feat_ExpandableNodeCache branch April 29, 2025 00:10
@AiYuZhen AiYuZhen deleted the Feat_ExpandableNodeCache branch April 29, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Table): 无法保持记录的折叠状态
2 participants