fix(Layout): missing route handler when url has #

[ArgoZhang]

Link issues

fixes #5794

Summary By Copilot

This pull request includes several changes to the BootstrapBlazor project, focusing on improving navigation handling and enhancing the robustness of the tab component. The most important changes include updating the URL handling in the Layout.razor.cs file and adding a null check in the Tab.razor.js file.

Improvements to navigation handling:

• src/BootstrapBlazor/Components/Layout/Layout.razor.cs: Changed the URL handling in the OnInitializedAsync method to use Navigation.ToAbsoluteUri and uri.LocalPath for creating the route context.

Enhancements to tab component:

• src/BootstrapBlazor/Components/Tab/Tab.razor.js: Added a null check for activeTab in the active function to prevent errors when no active tab is present.
• src/BootstrapBlazor/Components/Tab/Tab.razor.js: Removed an unnecessary comment and ensured the calculation of the right position for the active tab item.

Regression?

• Yes
• No

Risk

• High
• Medium
• Low

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Improve URL handling and tab navigation robustness in the BootstrapBlazor component library

Bug Fixes:

• Fix route handling for URLs containing hash (#) by using absolute URI and local path
• Add null check to prevent errors when no active tab is present

Enhancements:

• Refactor URL parsing method in Layout component to use more robust navigation URI handling
• Improve tab navigation positioning logic

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request focuses on improving navigation handling in the Layout component and enhancing the robustness of the Tab component. The URL handling in Layout.razor.cs was updated to use Navigation.ToAbsoluteUri and uri.LocalPath for creating the route context. A null check was added in Tab.razor.js to prevent errors when no active tab is present.

Sequence diagram for route handling in Layout component

sequenceDiagram
  participant LayoutComponent as Layout
  participant NavigationManager as NavManager
  participant RouteTableFactory as Factory
  participant AuthenticationHandler as Handler

  Layout->>NavManager: Get Navigation.Uri
  NavManager-->>Layout: Returns Navigation.Uri
  Layout->>NavManager: Call ToAbsoluteUri(Navigation.Uri)
  NavManager-->>Layout: Returns Absolute Uri
  Layout->>Factory: Create RouteTable with uri.LocalPath
  Factory-->>Layout: Returns RouteContext
  Layout->>Handler: IsAuthorizedAsync(ServiceProvider, AuthenticationStateTask, Resource)
  Handler-->>Layout: Returns IsAuthenticated

Loading

File-Level Changes

Change	Details	Files
Improved URL handling in the Layout component to correctly create the route context.	Utilized Navigation.ToAbsoluteUri to obtain the absolute URI. Extracted the local path from the URI using uri.LocalPath for route context creation.	src/BootstrapBlazor/Components/Layout/Layout.razor.cs
Enhanced the Tab component's JavaScript logic to prevent errors when no active tab is present and to ensure correct positioning of the active tab item.	Added a null check for activeTab to avoid errors when no tab is active. Ensured the calculation of the right position for the active tab item.	src/BootstrapBlazor/Components/Tab/Tab.razor.js

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#5794	The application should not throw an exception when the URL contains a '#'.	✅

Possibly linked issues

• bug(Layout): missing route handler when url has # #5794: The PR fixes an issue in the Layout component that caused incorrect URL handling when the URL contains a #. This fixes the pagination redirecting to the root path because the href was set to #.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

• The summary mentions improvements to navigation handling and enhancements to the tab component, but it doesn't explicitly state the problem being solved in issue bug(Layout): missing route handler when url has # #5794.
• The change in Layout.razor.cs uses uri.LocalPath, consider adding a comment explaining why ToBaseRelativePath was not sufficient.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (30ab0b3) to head (534c3d6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5795   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        30062     30062           
  Branches      4244      4244           
=========================================
  Hits         30062     30062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.