feat(Layout): add style for tab context menu #5735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request focuses on improving the styling of the layout and tabs components. The changes include fixing a syntax issue, adjusting the layout's main section, and moving tab styling from the Updated class diagram for Layout and Tab componentsclassDiagram
class Layout {
--bb-layout-header-background
--bb-layout-header-border-color
--bb-layout-banner-border-color
--bb-layout-sider-background
--bb-layout-footer-background
--bb-layout-footer-border-color
--bb-layout-header-height
--bb-layout-footer-height
--bb-layout-sider-width
--bb-layout-height
layout-main
}
note for Layout "Styling adjusted for .tabs and .bb-cm-zone > .tabs within layout-main"
class Tab {
--bb-tabs-item-padding
--bb-tabs-item-height
--bb-tabs-item-active-color
--bb-tabs-item-hover-background
--bb-tabs-item-border-color
--bb-tabs-item-active-border-color
--bb-tabs-item-font-size
--bb-tabs-item-border-radius
--bb-tabs-dropdown-item-padding
--bb-tabs-dropdown-item-height
--bb-tabs-dropdown-item-hover-background
--bb-tabs-dropdown-item-active-background
--bb-tabs-dropdown-item-active-color
--bb-tabs-dropdown-item-font-size
--bb-tabs-dropdown-menu-border-color
--bb-tabs-dropdown-menu-background
--bb-tabs-dropdown-menu-box-shadow
--bb-tabs-dropdown-menu-border-radius
--bb-tabs-border-color
--bb-tabs-background
--bb-tabs-border-radius
--bb-tabs-card-header-border-color
--bb-tabs-card-header-background
--bb-tabs-card-header-border-radius
--bb-tabs-card-body-border-color
--bb-tabs-card-body-background
--bb-tabs-card-body-border-radius
}
note for Tab "Redundant tab styling removed from Tab.razor.scss"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider if the BOM character fix should be a separate commit.
- Moving the tab styling seems like a good change to keep concerns separated.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5735 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29877 29877
Branches 4237 4237
=========================================
Hits 29877 29877 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5734
Summary By Copilot
This pull request includes changes to the
Layout.razor.scssandTab.razor.scssfiles to improve the styling of the layout and tabs components. The most important changes include fixing a syntax issue, adjusting the layout's main section, and moving tab styling from theTab.razor.scssfile to theLayout.razor.scssfile.Styling improvements:
src/BootstrapBlazor/Components/Layout/Layout.razor.scss: Fixed a syntax issue by removing a BOM character at the beginning of the file.src/BootstrapBlazor/Components/Layout/Layout.razor.scss: Adjusted thelayout-mainsection to include new styles for.tabsand.bb-cm-zone > .tabs, improving their appearance and layout.File restructuring:
src/BootstrapBlazor/Components/Tab/Tab.razor.scss: Removed redundant tab styling that was moved toLayout.razor.scssto ensure a cleaner and more maintainable codebase.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve tab context menu styling and layout by consolidating styles and adjusting layout main section
Bug Fixes:
Enhancements: