-
-
Notifications
You must be signed in to change notification settings - Fork 331
feat(Tab): add OnToolbarRefreshCallback parameter #5696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a try-catch block around the
OnToolbarRefreshCallback
invocation to handle potential exceptions.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5696 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 29789 29792 +3
Branches 4223 4224 +1
=========================================
+ Hits 29789 29792 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5695
Summary By Copilot
This pull request includes several updates to the
Tabs
component in theBootstrapBlazor
project. The changes focus on adding a new callback method for the toolbar refresh button, updating the localization files, and modifying the unit tests to cover the new functionality.Enhancements to Tabs Component:
New Callback Method:
OnToolbarRefreshCallback
to theTab
component to handle the toolbar refresh button click event. (src/BootstrapBlazor/Components/Tab/Tab.razor.cs
)OnRefreshAsync
method to invokeOnToolbarRefreshCallback
if it is set. (src/BootstrapBlazor/Components/Tab/Tab.razor.cs
)Localization Updates:
OnToolbarRefreshCallback
attribute and its behavior. (src/BootstrapBlazor.Server/Locales/en-US.json
)src/BootstrapBlazor.Server/Locales/zh-CN.json
)Component Samples:
Tabs.razor
sample file to demonstrate the usage of the newOnToolbarRefreshCallback
attribute. (src/BootstrapBlazor.Server/Components/Samples/Tabs.razor
)Unit Tests:
ShowToolbar_Ok
test to verify the functionality of theOnToolbarRefreshCallback
attribute. (test/UnitTest/Components/TabTest.cs
) [1] [2] [3]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Adds a new OnToolbarRefreshCallback parameter to the Tab component, allowing developers to execute custom logic when the toolbar refresh button is clicked.
New Features:
Tests: