feat(Tab): add TabStyle parameter #5640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a new 'Chrome' tab style to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a fallback or default behavior for unsupported tab styles to ensure robustness.
- Ensure that the new 'Chrome' tab style is consistent with existing design guidelines and user expectations for the application.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 653 653
Lines 29368 29373 +5
Branches 4183 4188 +5
=========================================
+ Hits 29368 29373 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5639
Summary By Copilot
This pull request introduces a new "Chrome" tab style to the
Tabcomponent in theBootstrapBlazorlibrary. The changes include updates to theTabs.razorfile, localization files, and the addition of a newTabStyleenum. The most important changes are listed below:New Tab Style Implementation:
src/BootstrapBlazor/Components/Tab/Tab.razor: Added logic to render tabs with the new "Chrome" style, including methods for rendering headers and disabled headers based on the tab style. [1] [2] [3]src/BootstrapBlazor/Components/Tab/Tab.razor.cs: Introduced theTabStyleproperty to theTabcomponent and updated methods to support the new style. [1] [2]Localization Updates:
src/BootstrapBlazor.Server/Locales/en-US.json: Added new localization entries for the "Chrome" tab style.src/BootstrapBlazor.Server/Locales/zh-CN.json: Added corresponding localization entries in Chinese.Style and CSS Changes:
src/BootstrapBlazor/Components/Tab/Tab.razor.scss: Added CSS rules for the "Chrome" tab style to define the appearance of the tabs and their headers.Enum Addition:
src/BootstrapBlazor/Enums/TabStyle.cs: Created a newTabStyleenum to define the available tab styles, including "Default" and "Chrome".Attribute and Method Updates:
src/BootstrapBlazor.Server/Components/Samples/Tabs.razor.cs: Updated attribute descriptions and added a new attribute forTabStyle. [1] [2] [3]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add a new 'Chrome' tab style to the Tab component, including updates to rendering logic, CSS, and localization files.
New Features:
Enhancements:
Documentation: