Skip to content

fix(Modal): add show style in multiple dialog mode #5617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025
Merged

fix(Modal): add show style in multiple dialog mode #5617

merged 2 commits into from
Mar 13, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Mar 13, 2025

Link issues

fixes #5616

Summary By Copilot

This pull request includes changes to the Modal component in the BootstrapBlazor library. The modifications aim to improve the structure and functionality of the modal dialog.

Improvements to modal structure:

Enhancements to modal functionality:

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where the modal was not displayed correctly in multiple dialog mode.

@bb-auto bb-auto bot added the enhancement New feature or request label Mar 13, 2025
Copy link
Contributor

sourcery-ai bot commented Mar 13, 2025

Reviewer's Guide by Sourcery

This pull request addresses issue #5616 by improving the modal component. The changes include formatting improvements in Modal.razor and ensuring the modal is displayed correctly by adding the show class during initialization in Modal.razor.js.

Sequence diagram for Modal initialization

sequenceDiagram
  participant JSInterop as JSInterop
  participant Modal as Modal Component

  Modal->>JSInterop: init(id, invoke, shownCallback, closeCallback)
  activate JSInterop
  JSInterop->>Modal: modal = new bootstrap.Modal(el, options)
  JSInterop->>Modal: modal._config.backdrop = 'static' (if multiple)
  JSInterop->>Modal: modal.handlerKeyboardAndBackdrop()
  JSInterop->>Modal: el.classList.add('show')
  deactivate JSInterop
Loading

File-Level Changes

Change Details Files
Improved the formatting of the Modal.razor file for better readability.
  • Reformatted the div element attributes to place data-bs-backdrop and data-bs-keyboard on separate lines.
src/BootstrapBlazor/Components/Modal/Modal.razor
Ensured the modal is displayed correctly by adding the 'show' class during initialization.
  • Added the show class to the modal element in the init function.
src/BootstrapBlazor/Components/Modal/Modal.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#5616 Support the display of multiple modal dialogs with fade effects.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.4.0 milestone Mar 13, 2025
@ArgoZhang ArgoZhang merged commit fd92ad9 into main Mar 13, 2025
3 checks passed
@ArgoZhang ArgoZhang deleted the fix-fade branch March 13, 2025 04:21
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It might be better to use classList.replace('hide', 'show') instead of classList.add('show') to avoid potential issues if the class is already present.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f820315) to head (e1a1818).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5617   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29622     29622           
  Branches      4165      4165           
=========================================
  Hits         29622     29622           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Modal): support IsFade multiple dialog mode
1 participant