fix(DateTimePicker): confirm button not work when set mode to DateTime #5572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request simplifies the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5572 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29605 29605
Branches 4172 4172
=========================================
Hits 29605 29605 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5562
Summary By Copilot
This pull request simplifies the
DateTimePickercomponent by removing unused code related to thedismissSelectorandEventHandler. The most important changes include the removal of thedismissSelectorattribute and associated event handling.Code simplification:
src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.js: Removed the import ofEventHandleras it is no longer needed.src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.js: Removed thedismissSelectorattribute from thedateTimePickerobject initialization. [1] [2]src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.js: Removed the conditional block that added an event listener for thedismissSelector.src/BootstrapBlazor/Components/DateTimePicker/DateTimePicker.razor.js: Removed the conditional block that removed the event listener for thedismissSelectorin thedisposefunction.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Simplify the DateTimePicker component by removing unused code related to the dismissSelector and EventHandler, which fixes an issue where the confirm button was not working correctly when the mode was set to DateTime.
Bug Fixes:
Enhancements: