Skip to content

fix(AutoComplete): OnEnterAsync/OnEscAsync not work #5474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Feb 28, 2025

Link issues

fixes #5467

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary of the changes

This pull request includes several changes to the BootstrapBlazor project, focusing on updating the project version, improving the AutoComplete component, and enhancing JavaScript functionality. The most important changes are summarized below:

Version Update:

AutoComplete Component Enhancements:

JavaScript Functionality Enhancements:

Summary by Sourcery

Fix the OnEnterAsync and OnEscAsync callbacks in the AutoComplete component and enhance its performance by using list slicing syntax. Update the project version to 9.4.3-beta01 and improve JavaScript functionality with asynchronous method invocations.

Bug Fixes:

  • Fix the issue where OnEnterAsync and OnEscAsync callbacks were not working in the AutoComplete component.

Enhancements:

  • Improve the AutoComplete component by using list slicing syntax for better performance and readability.

Copy link
Contributor

sourcery-ai bot commented Feb 28, 2025

Reviewer's Guide by Sourcery

This pull request addresses issue #5467 by updating the AutoComplete component in the BootstrapBlazor project to fix the OnEnterAsync and OnEscAsync functionalities. The changes include updating the project version, modifying the AutoComplete component's C# and JavaScript files to enhance list handling and asynchronous method invocations.

Sequence diagram for enhanced JavaScript functionality in AutoComplete

sequenceDiagram
    participant User
    participant AutoCompleteComponent
    participant JavaScript
    User->>AutoCompleteComponent: Keyup event (Enter/Escape)
    AutoCompleteComponent->>JavaScript: handlerKeyup
    JavaScript->>AutoCompleteComponent: invokeMethodAsync('EnterCallback', input.value) on Enter
    JavaScript->>AutoCompleteComponent: invokeMethodAsync('EscCallback') on Escape
Loading

File-Level Changes

Change Details Files
Updated project version to a new beta release.
  • Changed project version from 9.4.2 to 9.4.3-beta01.
src/BootstrapBlazor/BootstrapBlazor.csproj
Enhanced the AutoComplete component's list handling in C#.
  • Replaced ToList() with new list slicing syntax ([.. Items]) for the Rows property.
  • Modified TriggerFilter method to use list slicing syntax instead of ToList().
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs
Improved JavaScript functionality for AutoComplete component.
  • Included invoke in the destructured object within handlerKeyup function.
  • Added asynchronous method invocations for EnterCallback and EscCallback.
src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#5467 Ensure the OnEnterAsync event in the AutoComplete component triggers the associated function when pressing enter.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Feb 28, 2025
@bb-auto bb-auto bot added this to the v9.3.0 milestone Feb 28, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang modified the milestones: v9.3.0, 9.4.0 Feb 28, 2025
@ArgoZhang ArgoZhang enabled auto-merge (squash) February 28, 2025 16:59
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (51f0063) to head (50cd3ca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5474   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          646       646           
  Lines        29373     29373           
  Branches      4134      4134           
=========================================
  Hits         29373     29373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 88ca87b into main Feb 28, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-auto branch February 28, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(AutoComplete): does not trigger OnEnterAsync event
1 participant