-
-
Notifications
You must be signed in to change notification settings - Fork 331
bug(EnableIpLocator): WebClientOptions parameter EnableIpLocator not work #5400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request fixes an issue where the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The same options object is being constructed in two different places, consider creating a shared method.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 645 645
Lines 29276 29280 +4
Branches 4135 4135
=========================================
+ Hits 29276 29280 +4 ☔ View full report in Codecov by Sentry. |
WebClientOptions parameter EnableIpLocator not work
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5399
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fixes a bug where the
EnableIpLocator
option was not working as expected. The fix ensures that theEnableIpLocator
option is correctly passed to the client-side JavaScript, enabling or disabling IP address resolution as intended.Bug Fixes:
EnableIpLocator
option inWebClientOptions
was not being correctly passed to the client-side JavaScript, preventing the IP address from being resolved.Enhancements:
EnableIpLocator
option to the client-side JavaScript to control IP address resolution.