-
-
Notifications
You must be signed in to change notification settings - Fork 331
feat(MaskService): add Selector parameter #5361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request introduces a Sequence diagram for Mask update with SelectorsequenceDiagram
participant JS
participant C#
C#->>JS: InvokeVoidAsync("update", Id, {Show, ContainerId, Selector})
JS->>JS: getContainerBySelector(options)
alt options.containerId exists
JS->>JS: getContainerById(options.containerId)
JS-->>JS: containerId
else options.selector exists
JS-->>JS: options.selector
else
JS-->>JS: null
end
JS->>JS: document.querySelector(selector)
JS-->>C#: void
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a check in
getContainerBySelector
to ensure the selector returns a single element. - The
getContainerById
function could be simplified to just return the template literal directly.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5361 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29212 29218 +6
Branches 4125 4125
=========================================
+ Hits 29212 29218 +6 ☔ View full report in Codecov by Sentry. |
add Selector parameter
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5358
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add support for CSS selectors when configuring the mask container. This allows for more dynamic and flexible placement of the mask element. Resolve an issue where the mask was not displaying correctly within its container.
New Features:
Selector
parameter to theMaskOption
class to provide more flexibility in specifying the mask's container element using a CSS selector.Bug Fixes:
Selector
parameter to allow specifying a CSS selector for the mask's container element, fixing issue feat(MaskService): addContainerCssClass
toMaskOption
. #5358