-
-
Notifications
You must be signed in to change notification settings - Fork 331
feat(IFrame): add OnReadyAsync callback #5350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis PR adds an OnReadyAsync callback to the IFrame component that gets executed when the iframe has fully loaded. The implementation involves adding a new parameter, updating the JS interop to trigger the callback on the frame's onload event, and revising tests to validate the new functionality. Sequence diagram for IFrame OnReadyAsync callbacksequenceDiagram
participant JS as JavaScript
participant IFrame as IFrame Component
participant Callback as OnReadyAsync Callback
Note over JS: Frame onload event occurs
JS->>IFrame: invokeMethodAsync("TriggerLoaded")
IFrame->>IFrame: TriggerLoaded()
IFrame->>Callback: await OnReadyAsync()
Callback-->>IFrame: (callback executed)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider renaming
TriggerPostData
andTriggerLoaded
toOnPostData
andOnReady
to align with .NET naming conventions for event callbacks. - The javascript execute function does not check if the frame is loaded before calling postMessage.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5350 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 644 644
Lines 29199 29206 +7
Branches 4123 4124 +1
=========================================
+ Hits 29199 29206 +7 ☔ View full report in Codecov by Sentry. |
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider consolidating the JavaScript functions into a single module for better organization.
- The JavaScript execute function should check if the frame is loaded before posting the message.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
add OnReadyAsync callback
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5349
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add an
OnReadyAsync
callback to theIFrame
component, which is triggered when the IFrame has finished loading.New Features:
OnReadyAsync
parameter to theIFrame
component to provide a callback that is invoked when the iframe content has fully loaded.Tests:
OnReadyAsync
callback.