-
-
Notifications
You must be signed in to change notification settings - Fork 331
doc(Meilisearch): FooterLogo support responsive #5156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the CacheManager to improve performance and adds a new CSS variable for the global search dialog. It also updates the JsonStringLocalizerFactory to remove an unnecessary exception. Class diagram showing CacheManager changesclassDiagram
class CacheManager {
-static IEnumerable~LocalizedString~ localizedItems
+static IEnumerable~LocalizedString~ GetAllStringsByTypeName(Assembly assembly, string typeName)
+static IEnumerable~LocalizedString~ GetJsonStringByTypeName(JsonLocalizationOptions option, Assembly assembly, string typeName, string cultureName)
note for CacheManager "Removed _locker field
Simplified locking logic"
}
Class diagram showing JsonStringLocalizerFactory changesclassDiagram
class JsonStringLocalizerFactory {
#string GetResourcePrefix(TypeInfo typeInfo)
note for JsonStringLocalizerFactory "Removed InvalidOperationException
from method signature"
}
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 635 635
Lines 28184 28184
Branches 4039 4039
=========================================
Hits 28184 28184 ☔ View full report in Codecov by Sentry. |
FooterLogo support responsive
Summary of the changes (Less than 80 chars)
简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号
Description
fixes #5155
Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update the caching mechanism for localized strings to improve performance and fix a potential deadlock issue.
Bug Fixes:
Enhancements: