Skip to content

doc(Meilisearch): FooterLogo support responsive #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 19, 2025
Merged

doc(Meilisearch): FooterLogo support responsive #5156

merged 8 commits into from
Jan 19, 2025

Conversation

ArgoZhang
Copy link
Collaborator

@ArgoZhang ArgoZhang commented Jan 19, 2025

FooterLogo support responsive

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #5155

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Update the caching mechanism for localized strings to improve performance and fix a potential deadlock issue.

Bug Fixes:

  • Fix a potential deadlock issue in the localization caching mechanism.

Enhancements:

  • Improve performance of the localization caching mechanism.

Copy link
Contributor

sourcery-ai bot commented Jan 19, 2025

Reviewer's Guide by Sourcery

This pull request refactors the CacheManager to improve performance and adds a new CSS variable for the global search dialog. It also updates the JsonStringLocalizerFactory to remove an unnecessary exception.

Class diagram showing CacheManager changes

classDiagram
    class CacheManager {
        -static IEnumerable~LocalizedString~ localizedItems
        +static IEnumerable~LocalizedString~ GetAllStringsByTypeName(Assembly assembly, string typeName)
        +static IEnumerable~LocalizedString~ GetJsonStringByTypeName(JsonLocalizationOptions option, Assembly assembly, string typeName, string cultureName)
        note for CacheManager "Removed _locker field
Simplified locking logic"
    }
Loading

Class diagram showing JsonStringLocalizerFactory changes

classDiagram
    class JsonStringLocalizerFactory {
        #string GetResourcePrefix(TypeInfo typeInfo)
        note for JsonStringLocalizerFactory "Removed InvalidOperationException
from method signature"
    }
Loading

File-Level Changes

Change Details Files
Refactor CacheManager to improve performance
  • Removed unused lock object.
  • Simplified the logic for retrieving localized items.
  • Removed unnecessary conditional compilation.
src/BootstrapBlazor/Services/CacheManager.cs
Add a new CSS variable for the global search dialog
  • Added --bb-global-search-main-max-height CSS variable.
src/BootstrapBlazor.Server/wwwroot/css/site.css
Remove unnecessary exception from JsonStringLocalizerFactory
  • Removed the InvalidOperationException from GetResourcePrefix method.
src/BootstrapBlazor/Localization/Json/JsonStringLocalizerFactory.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#5154 Remove the lock from the CacheManager to improve performance
#5154 Fix an issue where the cache was not being updated correctly

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the enhancement New feature or request label Jan 19, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 19, 2025
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (951c1c6) to head (4536058).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          635       635           
  Lines        28184     28184           
  Branches      4039      4039           
=========================================
  Hits         28184     28184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit c794a1e into main Jan 19, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the test-search branch January 19, 2025 03:02
@bb-auto bb-auto bot added documentation Improvements or additions to documentation and removed enhancement New feature or request labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc(Meilisearch): FooterLogo support responsive
1 participant